Open
Conversation
EAOlenskaia
reviewed
Dec 22, 2025
tests.py
Outdated
| @@ -21,4 +24,154 @@ def test_add_new_book_add_two_books(self): | |||
| assert len(collector.get_books_rating()) == 2 | |||
There was a problem hiding this comment.
Нужно исправить:
Данный метод отсутствует в BooksCollector, тест падает. Нужно либо удалить тест полностью, либо исправить вызываемый метод на существующий.
tests.py
Outdated
| ("It", "Ужасы"), | ||
| ]) | ||
| def test_set_book_genre_valid(self, name, genre): | ||
| self.add_new_book(name) |
There was a problem hiding this comment.
Нужно исправить здесь и далее:
self вызывает метод класса TestBooksCollector, а здесь необходимо вызывать BooksCollector
tests.py
Outdated
| ("Ужасы", ["Book2"]), | ||
| ]) | ||
| def test_get_books_with_specific_genre(self, expected, collector, genre=None): | ||
| c = collector |
There was a problem hiding this comment.
Нужно исправить:
фикстура collector отсутствует
tests.py
Outdated
| c.delete_book_from_favorites("It") | ||
| assert c.get_list_of_favorites_books() == ["The Hobbit"] | ||
|
|
||
| def add_new_book(self, name): |
There was a problem hiding this comment.
Нужно исправить:
Здесь и далее эти заглушки лишние
added 2 commits
December 24, 2025 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.